check.cpp

Go to the documentation of this file.

 
/*
All original material Copyright (C) 2002-2025 UFO: Alien Invasion.
 
Copyright (C) 1997-2001 Id Software, Inc.
 
This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License
as published by the Free Software Foundation; either version 2
of the License, or (at your option) any later version.
 
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 
See the GNU General Public License for more details.
 
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 
*/
 
#include "check.h"
#include "../common/shared.h"
#include "../common/bspfile.h"
#include "../common/scriplib.h"
#include "../../../shared/entitiesdef.h"
#include "checklib.h"
#include "../bsp.h"
#include "../ufo2map.h"
 
compositeSide_t compositeSides[MAX_MAP_SIDES / 2];
int numCompositeSides;

#define CH_DIST_EPSILON 0.001f
#define CH_DIST_EPSILON_SQR 0.000001
 
#define CH_DIST_EPSILON_COLLINEAR_POINTS 0.02f 

#define COS_EPSILON 0.9999f

#define SIN_EPSILON 0.0001f

typedef enum {
    PIB_EXCL_SURF,              
    PIB_INCL_SURF_EXCL_EDGE,    
    PIB_INCL_SURF,              
    PIB_ON_SURFACE_ONLY         
} pointInBrush_t;

#define NEARDOWN_COS 0.985

static bool Check_SidePointsDown (const side_t* s)
{
    const vec3_t down = {0.0f, 0.0f, -1.0f};
    const plane_t* plane = &mapplanes[s->planenum];
    const float dihedralCos = DotProduct(plane->normal, down);
    return dihedralCos >= NEARDOWN_COS;
}

static inline float Check_PointPlaneDistance (const vec3_t point, const plane_t* plane)
{
    /* normal should have a magnitude of one */
    assert(fabs(VectorLengthSqr(plane->normal) - 1.0f) < CH_DIST_EPSILON);
 
    return DotProduct(point, plane->normal) - plane->dist;
}

static bool FacingAndCoincidentTo (const side_t* side1, const side_t* side2)
{
    const plane_t* plane1 = &mapplanes[side1->planenum];
    const plane_t* plane2 = &mapplanes[side2->planenum];
    float distance;
 
    const float dihedralCos = DotProduct(plane1->normal, plane2->normal);
    if (dihedralCos >= -COS_EPSILON)
        return false; /* not facing each other */
 
    /* calculate the distance of point from plane2. as we have established that the
     * plane's normals are antiparallel, and plane1->planeVector[0] is a point on plane1
     * (that was supplied in the map file), this is the distance
     * between the planes */
    distance = Check_PointPlaneDistance(plane1->planeVector[0], plane2);
 
    return fabs(distance) < CH_DIST_EPSILON;
}

static bool ParallelAndCoincidentTo (const side_t* side1, const side_t* side2)
{
    float distance;
    const plane_t* plane1 = &mapplanes[side1->planenum];
    const plane_t* plane2 = &mapplanes[side2->planenum];
    const float dihedralCos = DotProduct(plane1->normal, plane2->normal);
    if (dihedralCos <= COS_EPSILON)
        return false; /* not parallel */
 
    distance = Check_PointPlaneDistance(plane1->planeVector[0], plane2);
 
    return fabs(distance) < CH_DIST_EPSILON;
}

static inline bool Check_IsPointInsideBrush (const vec3_t point, const mapbrush_t* brush, const pointInBrush_t mode)
{
    int numPlanes = 0; /* how many of the sides the point is on. on 2 sides, means on an edge. on 3 a vertex */
    /* PIB_INCL_SURF is the default */
    /* apply epsilon the other way if the surface is excluded */
    const float epsilon = CH_DIST_EPSILON * (mode == PIB_EXCL_SURF ? -1.0f : 1.0f);
 
    for (int i = 0; i < brush->numsides; i++) {
        const plane_t* plane = &mapplanes[brush->original_sides[i].planenum];
 
        /* if the point is on the wrong side of any face, then it is outside */
        /* distance to one of the planes of the sides, negative implies the point is inside this plane */
        const float dist = Check_PointPlaneDistance(point, plane);
        if (dist > epsilon)
            return false;
 
        numPlanes += fabs(dist) < CH_DIST_EPSILON ? 1 : 0;
    }
 
    if (mode == PIB_ON_SURFACE_ONLY && numPlanes == 0)
        return false; /* must be on at least one surface */
 
    if (mode == PIB_INCL_SURF_EXCL_EDGE && numPlanes > 1)
        return false; /* must not be on more than one side, that would be an edge */
 
    /* inside all planes, therefore inside the brush */
    return true;
}

static bool Check_SurfProp (const int flag, const side_t* s)
{
    const ptrdiff_t indexSide = s - brushsides;
    const brush_texture_t* tex = &side_brushtextures[indexSide];
    switch (flag) {
    case SURF_NODRAW:
        return Q_streq(tex->name, "tex_common/nodraw");
    case CONTENTS_LADDER:
        return Q_streq(tex->name, "tex_common/ladder");
    case CONTENTS_WEAPONCLIP:
        return Q_streq(tex->name, "tex_common/weaponclip");
    case CONTENTS_ACTORCLIP:
        return Q_streq(tex->name, "tex_common/actorclip");
    case CONTENTS_LIGHTCLIP:
        return Q_streq(tex->name, "tex_common/lightclip");
    case CONTENTS_ORIGIN:
        return Q_streq(tex->name, "tex_common/origin");
    default:
        return false;
    }
}

static bool Check_SurfProps (const int flags, const side_t* s)
{
    const ptrdiff_t indexSide = s - brushsides;
    const brush_texture_t* tex = &side_brushtextures[indexSide];
    const char* texname = tex->name;
    assert(flags & (SURF_NODRAW | MASK_CLIP));
 
    if ((flags & SURF_NODRAW) && Q_streq(texname, "tex_common/nodraw"))
        return true;
 
    if ((flags & CONTENTS_WEAPONCLIP) && Q_streq(texname, "tex_common/weaponclip"))
        return true;
 
    if ((flags & CONTENTS_ACTORCLIP) && Q_streq(texname, "tex_common/actorclip"))
        return true;
 
    if ((flags & CONTENTS_LIGHTCLIP) && Q_streq(texname, "tex_common/lightclip"))
        return true;
 
    if ((flags & CONTENTS_LADDER) && Q_streq(texname, "tex_common/ladder"))
        return true;
 
    if ((flags & CONTENTS_ORIGIN) && Q_streq(texname, "tex_common/origin"))
        return true;
 
    return false;
}

static bool Check_IsOptimisable (const mapbrush_t* b)
{
    const entity_t* e = &entities[b->entitynum];
    const char* name = ValueForKey(e, "classname");
    int numNodraws = 0;
 
    if (!Q_streq(name, "func_group") && !Q_streq(name, "worldspawn"))
        return false;/* other entities, eg func_breakable are no use */
 
    /* content flags should be the same on all faces, but we shall be suspicious */
    for (int i = 0; i < b->numsides; i++) {
        const side_t* side = &b->original_sides[i];
        if (Check_SurfProps(CONTENTS_ORIGIN | MASK_CLIP, side))
            return false;
        if (side->contentFlags & CONTENTS_TRANSLUCENT)
            return false;
        numNodraws += Check_SurfProp(SURF_NODRAW, side) ? 1 : 0;
    }
 
    /* all nodraw brushes are special too */
    return numNodraws == b->numsides ? false : true;
}

static bool Check_BoundingBoxIntersects (const mapbrush_t* a, const mapbrush_t* b)
{
    for (int i = 0; i < 3; i++)
        if (a->mbBox.mins[i] - CH_DIST_EPSILON >= b->mbBox.maxs[i] || a->mbBox.maxs[i] <= b->mbBox.mins[i] - CH_DIST_EPSILON)
            return false;
 
    return true;
}

static void Check_NearList (void)
{
    /* this function may be called more than once, but we only want this done once */
    static bool done = false;
    mapbrush_t* bbuf[MAX_MAP_BRUSHES];/*< store pointers to brushes here and then malloc them when we know how many */
 
    if (done)
        return;
 
    /* make a list for iBrush*/
    for (int i = 0; i < nummapbrushes; i++) {
        mapbrush_t* iBrush = &mapbrushes[i];
        int j, numNear;
 
        /* test all brushes for nearness to iBrush */
        for (j = 0, numNear = 0 ; j < nummapbrushes; j++) {
            mapbrush_t* jBrush = &mapbrushes[j];
 
            if (i == j) /* do not list a brush as being near itself - not useful!*/
                continue;
 
            if (!Check_BoundingBoxIntersects(iBrush, jBrush))
                continue;
 
            /* near, therefore add to temp list for iBrush */
            assert(numNear < nummapbrushes);
            bbuf[numNear++] = jBrush;
        }
 
        iBrush->numNear = numNear;
        if (!numNear)
            continue;
 
        /* now we know how many, we can malloc. then copy the pointers */
        iBrush->nearBrushes = Mem_AllocTypeN(mapbrush_t* , numNear);
 
        if (!iBrush->nearBrushes)
            Sys_Error("Check_Nearlist: out of memory");
 
        for (j = 0; j < numNear; j++)
            iBrush->nearBrushes[j] = bbuf[j];
    }
 
    done = true;
}

static bool Check_SideIsInBrush (const side_t* side, const mapbrush_t* brush, pointInBrush_t mode)
{
    const winding_t* w = side->winding;
 
    assert(w->numpoints > 0);
 
    for (int i = 0; i < w->numpoints ; i++)
        if (!Check_IsPointInsideBrush(w->p[i], brush, mode))
            return false;
 
    return true;
}
 
#if 0
static void Check_SetError (side_t* s)
{
    const ptrdiff_t index = s - brushsides;
    brush_texture_t* tex = &side_brushtextures[index];
 
    Q_strncpyz(tex->name, "tex_common/error", sizeof(tex->name));
}
#endif

static bool Check_SidesTouch (side_t* a, side_t* b)
{
    side_t* s[2];
 
    s[0] = a;
    s[1] = b;
 
    for (int i = 0; i < 2; i++) {
        const winding_t* w = s[i]->winding; /* winding from one of the sides */
        const mapbrush_t* brush = s[i ^ 1]->brush; /* the brush that the other side belongs to */
 
        for (int j = 0; j < w->numpoints ; j++) {
            if (Check_IsPointInsideBrush(w->p[j], brush, PIB_INCL_SURF))
                return true;
        }
    }
    return false;
}

static void Check_FindCompositeSides (void)
{
    static bool done = false;
    int i, j, k, l, numMembers, numDone = 0, numTodo;
 
    /* store pointers to sides here and then malloc them when we know how many.
     * divide by 4 becuase, the minimum number of sides for a brush is 4, so if
     * all brushes were lined up, and had one side as a member, that would be their number */
    side_t* sbuf[MAX_MAP_SIDES / 4];
 
    mapbrush_t* bDone[MAX_MAP_SIDES]; /*< an array of brushes to check if the composite propagates across */
    mapbrush_t* bTodo[MAX_MAP_SIDES]; /*< an array of brushes that have been checked, without this it would never stop */
 
    /* this function may be called more than once, but we only want this done once */
    if (done)
        return;
 
    Check_NearList();
 
    /* check each brush, iBrush */
    for (i = 0; i < nummapbrushes; i++) {
        mapbrush_t* iBrush = &mapbrushes[i];
 
        if (!Check_IsOptimisable(iBrush))
            continue; /* skip clips etc */
 
        /* check each side, iSide, of iBrush for being the seed of a composite face */
        for (int is = 0; is < iBrush->numsides; is++) {
            side_t* iSide = &iBrush->original_sides[is];
 
            /* do not find the same composite again. no nodraws
             * AddBrushBevels creates sides without windings. skip these too */
            if (iSide->isCompositeMember || Check_SurfProp(SURF_NODRAW, iSide) || !iSide->winding)
                continue;
 
            /* start making the list of brushes in the composite,
             * we will only keep it if the composite has more than member */
            sbuf[0] = iSide; /* set iSide->isCompositeMember = true later, if we keep the composite */
            numMembers = 1;
 
            /* add neighbouring brushes to the list to check for composite propagation */
            numTodo = 0;
            for (j = 0; j < iBrush->numNear; j++)
                if (Check_IsOptimisable(iBrush->nearBrushes[j])) {
                    bTodo[numTodo++] = iBrush->nearBrushes[j];
                }
 
            /* this brush's nearlist is listed for checking, so it is done */
            bDone[numDone++] = iBrush;
 
            while (numTodo > 0) {
                mapbrush_t* bChecking = bTodo[--numTodo];
                if (bChecking == nullptr)
                    continue;
                bDone[numDone++] = bChecking; /* remember so it is not added to the todo list again */
 
                for (j = 0; j < bChecking->numsides; j++) {
                    side_t* sChecking = &bChecking->original_sides[j];
 
                    if (Check_SurfProp(SURF_NODRAW, sChecking) || !sChecking->winding)
                        continue; /* no nodraws in composites. see comment above above regarding winding*/
 
                    if (ParallelAndCoincidentTo(iSide, sChecking)) {
 
                        /* test if sChecking intersects or touches any of sides that are already in the composite*/
                        for (k = 0; k < numMembers; k++) {
                            if (Check_SidesTouch(sChecking, sbuf[k])) {
                                const mapbrush_t* newMembersBrush = sChecking->brush;
                                sbuf[numMembers++] = sChecking; /* add to the array of members */
                                sChecking->isCompositeMember = true;
 
                                /* add this brush's nearList to the todo list, as the compostite may propagate through it */
                                for (l = 0; l < newMembersBrush->numNear;l++) {
                                    mapbrush_t* nearListBrush = newMembersBrush->nearBrushes[l];
 
                                    if (!Check_IsOptimisable(nearListBrush))
                                        continue; /* do not propogate across clips etc */
 
                                    /* only add them to the todo list if they are not on the done list
                                     * as a brush cannot have parallel sides, this also ensures the same side
                                     * is not added to a composite more than once */
                                    for (int m = 0; m < numDone; m++) {
                                        if (nearListBrush == bDone[m])
                                            goto skip_add_brush_to_todo_list;
                                    }
                                    bTodo[numTodo++] = nearListBrush;
 
                                    skip_add_brush_to_todo_list:
                                    ; /* there must be a statement after the label, ";" will do */
                                }
                                goto next_brush_todo; /* need not test any more sides of this brush, if a member is found */
                            }
                        }
                    }
                }
                next_brush_todo:
                ;
            }
 
            if (numMembers > 1) { /* composite found */
                side_t** sidesInNewComposite = Mem_AllocTypeN(side_t* , numMembers);
 
                if (!sidesInNewComposite)
                    Sys_Error("Check_FindCompositeSides: out of memory");
 
                /* this was not done before for the first side, as we did not know it would have at least 2 members */
                iSide->isCompositeMember = true;
 
                compositeSides[numCompositeSides].numMembers = numMembers;
                compositeSides[numCompositeSides].memberSides = sidesInNewComposite;
 
                for (j = 0; j < numMembers; j++) {
                    compositeSides[numCompositeSides].memberSides[j] = sbuf[j];
                }
                numCompositeSides++;
            }
        }
    }
 
    Check_Printf(VERB_EXTRA, false, -1, -1, "%i composite sides found\n", numCompositeSides);
 
    done = true;
}

static int Check_EdgePlaneIntersection (const vec3_t vert1, const vec3_t vert2, const plane_t* plane, vec3_t intersection)
{
    vec3_t direction; /* a vector in the direction of the line */
    vec3_t lineToPlane; /* a line from vert1 on the line to a point on the plane */
    float sinVal; /* sine of angle to plane, cosine of angle to normal */
    float param; /* param in line equation  line = vert1 + param * (vert2 - vert1) */
    float length; /* length of the edge */
 
    VectorSubtract(vert2, vert1, direction);/*< direction points from vert1 to vert2 */
    length = VectorLength(direction);
    if (length < DIST_EPSILON)
        return false;
    sinVal = DotProduct(direction, plane->normal) / length;
    if (fabs(sinVal) < SIN_EPSILON)
        return false;
    VectorSubtract(plane->planeVector[0], vert1, lineToPlane);
    param = DotProduct(plane->normal, lineToPlane) / DotProduct(plane->normal, direction);
 
    /* direction should point from vert1 to intersection */
    VectorMul(param, direction, direction);
    VectorAdd(vert1, direction, intersection);
    /* param is now the distance along the edge from vert1 */
    param = param * length;
    return (param > CH_DIST_EPSILON) && (param < (length - CH_DIST_EPSILON));
}

static bool Check_WindingIntersects (const winding_t* winding, const mapbrush_t* brush)
{
    vec3_t intersection;
    int vi, bi;
 
    for (bi = 0; bi < brush->numsides; bi++) {
        for (vi = 0; vi < winding->numpoints; vi++) {
            const int val = vi + 1;
            const int vj = (winding->numpoints == val) ? 0 : val;
            if (Check_EdgePlaneIntersection(winding->p[vi], winding->p[vj], &mapplanes[brush->original_sides[bi].planenum], intersection))
                if (Check_IsPointInsideBrush(intersection, brush, PIB_INCL_SURF_EXCL_EDGE))
                    return true;
        }
    }
    return false;
}

void Check_BrushIntersection (void)
{
    /* initialise mapbrush_t.nearBrushes */
    Check_NearList();
 
    for (int i = 0; i < nummapbrushes; i++) {
        const mapbrush_t* iBrush = &mapbrushes[i];
 
        if (!Check_IsOptimisable(iBrush))
            continue;
 
        for (int j = 0; j < iBrush->numNear; j++) {
            const mapbrush_t* jBrush = iBrush->nearBrushes[j];
 
            if (!Check_IsOptimisable(jBrush))
                continue;
 
            /* check each side of i for intersection with brush j */
            for (int is = 0; is < iBrush->numsides; is++) {
                const winding_t* winding = (iBrush->original_sides[is].winding);
                if (Check_WindingIntersects(winding, jBrush)) {
                    Check_Printf(VERB_CHECK, false, iBrush->entitynum, iBrush->brushnum, "intersects with brush %i (entity %i)\n", jBrush->brushnum, jBrush->entitynum);
                    break;
                }
            }
        }
    }
}

static bool Check_EdgeEdgeIntersection (const vec3_t e1p1, const vec3_t e1p2,
                    const vec3_t e2p1, const vec3_t e2p2, vec3_t intersection)
{
    vec3_t dir1, dir2, unitDir1, unitDir2;
    vec3_t dirClosestApproach, from1To2, e1p1ToIntersection, e2p1ToIntersection;
    vec3_t cross1, cross2;
    float cosAngle, length1, length2, dist, magCross2, param1;
    float e1p1Dist, e2p1Dist;
 
    VectorSubtract(e1p2, e1p1, dir1);
    VectorSubtract(e2p2, e2p1, dir2);
    length1 = VectorLength(dir1);
    length2 = VectorLength(dir2);
 
    if (length1 < CH_DIST_EPSILON || length2 < CH_DIST_EPSILON)
        return false; /* edges with no length cannot intersect */
 
    VectorScale(dir1, 1.0f / length1, unitDir1);
    VectorScale(dir2, 1.0f / length2, unitDir2);
 
    cosAngle = fabs(DotProduct(unitDir1, unitDir2));
 
    if (cosAngle >= COS_EPSILON)
        return false; /* parallel lines either do not intersect, or are coincident */
 
    CrossProduct(unitDir1, unitDir2, dirClosestApproach);
    VectorNormalize(dirClosestApproach);
 
    VectorSubtract(e2p1, e1p1, from1To2);
    dist = fabs(DotProduct(dirClosestApproach, from1To2));
 
    if (dist > CH_DIST_EPSILON)
        return false; /* closest approach of skew lines is nonzero: no intersection */
 
    CrossProduct(from1To2, dir2, cross1);
    CrossProduct(dir1, dir2, cross2);
    magCross2 = VectorLength(cross2);
    param1 = DotProduct(cross1, cross2) / (magCross2 * magCross2);
    VectorScale(dir1, param1, e1p1ToIntersection);
    VectorAdd(e1p1, e1p1ToIntersection, intersection);
    e1p1Dist = DotProduct(e1p1ToIntersection, unitDir1);
 
    if (e1p1Dist < CH_DIST_EPSILON || e1p1Dist > (length1 - CH_DIST_EPSILON))
        return false; /* intersection is not between vertices of edge 1 */
 
    VectorSubtract(intersection, e2p1, e2p1ToIntersection);
    e2p1Dist = DotProduct(e2p1ToIntersection, unitDir2);
    if (e2p1Dist < CH_DIST_EPSILON || e2p1Dist > (length2 - CH_DIST_EPSILON))
        return false; /* intersection is not between vertices of edge 2 */
 
    return true;
}
 
#if 0 /* not used since z-fight test changed to calculate area of overlap instead */
static bool Check_PointsAreCollinear (const vec3_t a, const vec3_t b, const vec3_t c)
{
    vec3_t d1, d2, d3, cross;
    float d1d, d2d, d3d, offLineDist;
 
    VectorSubtract(a, b, d1);
    VectorSubtract(a, c, d2);
    VectorSubtract(b, c, d3);
 
    d1d = VectorLength(d1);
    d2d = VectorLength(d2);
    d3d = VectorLength(d3);
 
    /* if 2 points are in the same place, we only have 2 points, which must be in a line */
    if (d1d < CH_DIST_EPSILON || d2d < CH_DIST_EPSILON || d3d < CH_DIST_EPSILON)
        return true;
 
    if (d1d >= d2d && d1d >= d3d) {
        CrossProduct(d2, d3, cross);
        offLineDist = VectorLength(cross) / d1d;
    } else if (d2d >= d1d && d2d >= d3d) {
        CrossProduct(d1, d3, cross);
        offLineDist = VectorLength(cross) / d2d;
    } else { /* d3d must be the largest */
        CrossProduct(d1, d2, cross);
        offLineDist = VectorLength(cross) / d3d;
    }
 
    return offLineDist < CH_DIST_EPSILON_COLLINEAR_POINTS;
}
#endif
 
static float Check_LongestEdge (const winding_t* w)
{
    float longestSqr = 0;
    for (int i = 0; i < w->numpoints; i++) {
        const int j = (i + 1) % w->numpoints;
        const float lengthSqr = VectorDistSqr(w->p[i], w->p[j]);
        longestSqr = longestSqr > lengthSqr ? longestSqr : lengthSqr;
    }
    return sqrt(longestSqr);
}
 
#define VERT_BUF_SIZE_DISJOINT_SIDES 21
#define OVERLAP_AREA_TOL 0.2f
#define OVERLAP_WIDTH_TOL 0.1f

static float Check_SidesOverlap (const side_t* s1, const side_t* s2)
{
    vec3_t vertbuf[VERT_BUF_SIZE_DISJOINT_SIDES];/* vertices of intersection of sides. arbitrary choice of size: more than 4 is unusual */
    int numVert = 0, i;
    winding_t* w[2];
    mapbrush_t* b[2];
 
    w[0] = s1->winding; w[1] = s2->winding;
    b[0] = s1->brush; b[1] = s2->brush;
 
    /* test if points from first winding are in (or on) brush that is parent of second winding
     * and vice - versa. i ^ 1 toggles */
    for (i = 0; i < 2; i++) {
        for (int j = 0; j < w[i]->numpoints ; j++) {
            if (Check_IsPointInsideBrush(w[i]->p[j], b[i ^ 1], PIB_INCL_SURF)) {
                if (numVert == VERT_BUF_SIZE_DISJOINT_SIDES) {
                    Check_Printf(VERB_CHECK, false, b[i]->entitynum, b[i]->brushnum, "warning: Check_SidesAreDisjoint buffer too small");
                    return -1.0f;
                }
                VectorCopy(w[i]->p[j], vertbuf[numVert]);
                numVert++;
            }
        }
    }
 
    /* test for intersections between windings*/
    for (i = 0; i < w[0]->numpoints; i++) {
        const int pointIndex = (i + 1) % w[0]->numpoints;
        for (int k = 0; k < w[1]->numpoints; k++) {
            const int pointIndex2 = (k + 1) % w[1]->numpoints;
            if (Check_EdgeEdgeIntersection(w[0]->p[i], w[0]->p[pointIndex], w[1]->p[k], w[1]->p[pointIndex2], vertbuf[numVert])) {
                numVert++; /* if intersection, keep it */
                if (numVert == VERT_BUF_SIZE_DISJOINT_SIDES) {
                    Check_Printf(VERB_CHECK, false, b[i]->entitynum, b[i]->brushnum, "warning: Check_SidesAreDisjoint buffer too small");
                    return -1.0f;
                }
            }
        }
    }
 
    if (numVert < 3)
        return -1.0f; /* must be at least 3 points to be not in a line */
 
    {
        /* make a winding, so WindingArea can be used */
        float overlapArea, longestEdge, width;
        winding_t* overlap = AllocWinding(numVert);
        overlap->numpoints = numVert;
        memcpy(overlap->p, vertbuf, numVert * sizeof(vec3_t));
        overlapArea = WindingArea(overlap);
#if 0
        if (overlapArea > OVERLAP_AREA_TOL) {
            for (int i = 0; i < numVert; i++) {
                vec3_t* v = &vertbuf[i];
                Com_Printf("(%f, %f, %f)\n", v[0], v[1], v[2]);
            }
        }
#endif
        /* small area, do not waste time calculating width */
        if (overlapArea < OVERLAP_AREA_TOL) {
            Mem_Free(overlap);
            return -1.0f;
        }
 
        longestEdge = Check_LongestEdge(overlap);
        width = overlapArea / longestEdge;
        Mem_Free(overlap);
        return width > OVERLAP_WIDTH_TOL ? width : -1.0f;
    }
 
#if 0
    {
        vec3_t from0to1, one, zero;
 
        /* skip past elements 0, 1, ... if they are coincident - to avoid division by zero */
        i = 0;
        do {
            i++;
            if ((i + 1) >= numVert)
                return false; /* not enough separated points - they must be in a line */
            VectorSubtract(vertbuf[i], vertbuf[i - 1], from0to1);
            VectorCopy(vertbuf[i - 1], zero);
            VectorCopy(vertbuf[i], one);
        } while (VectorLength(from0to1) < CH_DIST_EPSILON);
 
        for (i++; i < numVert; i++) {
            if (!Check_PointsAreCollinear(zero, one, vertbuf[i])) {
                return true; /* 3 points not in a line, there is overlap */
            }
        }
    }
 
    return false; /* all points are collinear */
#endif
}

void CheckZFighting (void)
{
    /* initialise mapbrush_t.nearBrushes */
    Check_NearList();
 
    /* loop through all pairs of near brushes */
    for (int i = 0; i < nummapbrushes; i++) {
        const mapbrush_t* iBrush = &mapbrushes[i];
 
        if (!Check_IsOptimisable(iBrush))
            continue; /* skip moving brushes, clips etc */
 
        for (int j = 0; j < iBrush->numNear; j++) {
            const mapbrush_t* jBrush = iBrush->nearBrushes[j];
 
            if ((iBrush->contentFlags & CONTENTS_LEVEL_ALL) != (jBrush->contentFlags & CONTENTS_LEVEL_ALL))
                continue; /* must be on the same level */
 
            if (!Check_IsOptimisable(jBrush))
                continue; /* skip moving brushes, clips etc */
 
            for (int is = 0; is < iBrush->numsides; is++) {
                const side_t* iSide = &iBrush->original_sides[is];
 
                if (Check_SurfProp(SURF_NODRAW, iSide))
                    continue; /* skip nodraws */
 
                if (Check_SidePointsDown(iSide))
                    continue; /* can't see these, view is always from above */
 
                /* check each side of brush j for doing the hiding */
                for (int js = 0; js < jBrush->numsides; js++) {
                    const side_t* jSide = &jBrush->original_sides[js];
 
                    /* skip nodraws */
                    if (Check_SurfProp(SURF_NODRAW, jSide))
                        continue;
 
#if 0
                    if (ParallelAndCoincidentTo(iSide, jSide))
                        if (jSide->planenum != jSide->planenum)
                            Com_Printf("CheckZFighting: plane indices %i %i \n",
                                iSide->planenum, jSide->planenum);
#endif
 
                    if (ParallelAndCoincidentTo(iSide, jSide) ) {
                        float overlapWidth = Check_SidesOverlap(iSide, jSide);
                        if ( overlapWidth > 0.0f) {
                            Check_Printf(VERB_CHECK, false, iBrush->entitynum, iBrush->brushnum,
                                "z-fighting with brush %i (entity %i). overlap width: %.3g units\n",
                                jBrush->brushnum, jBrush->entitynum, overlapWidth);
#if 0
                            Check_SetError(iSide);
                            Check_SetError(jSide);
#endif
                        }
                    }
                }
            }
        }
    }
}

void Check_ContainedBrushes (void)
{
    /* initialise mapbrush_t.nearBrushes */
    Check_NearList();
 
    for (int i = 0; i < nummapbrushes; i++) {
        mapbrush_t* iBrush = &mapbrushes[i];
 
        /* do not check for brushes inside special (clip etc) brushes */
        if (!Check_IsOptimisable(iBrush))
            continue;
 
        for (int j = 0; j < iBrush->numNear; j++) {
            mapbrush_t* jBrush = iBrush->nearBrushes[j];
            int numSidesInside = 0;
 
            if (jBrush->contentFlags & CONTENTS_ORIGIN)
                continue; /* origin brushes are allowed inside others */
 
            for (int js = 0; js < jBrush->numsides; js++) {
                const side_t* jSide = &jBrush->original_sides[js];
 
                if (Check_SideIsInBrush(jSide, iBrush, PIB_INCL_SURF))
                    numSidesInside++;
            }
 
            if (numSidesInside == jBrush->numsides) {
                Check_Printf(VERB_CHECK, false, jBrush->entitynum, jBrush->brushnum, "inside brush %i (entity %i)\n",
                            iBrush->brushnum, iBrush->entitynum);
            }
        }
    }
}

static int Check_LevelForNodraws (const side_t* coverer, const side_t* coveree)
{
    return !(CONTENTS_LEVEL_ALL & ~coverer->contentFlags & coveree->contentFlags);
}
 
static void Check_SetNodraw (side_t* s)
{
    const ptrdiff_t index = s - brushsides;
    brush_texture_t* tex = &side_brushtextures[index];
 
    Q_strncpyz(tex->name, "tex_common/nodraw", sizeof(tex->name));
 
    /* do not actually set the flag that will be written back on -fix
     * the texture is set, this should trigger the flag to be set
     * in compile mode. check should behave the same as fix.
     * The flag must be set in compile mode, as SetImpliedFlags calls are before the
     * CheckNodraws call */
    if (!(config.fixMap || config.performMapCheck))
        tex->surfaceFlags |= SURF_NODRAW;
 
    s->surfaceFlags &= ~SURF_PHONG;
    tex->surfaceFlags &= ~SURF_PHONG;
    s->surfaceFlags |= SURF_NODRAW;
}
 
#define CH_COMP_NDR_EDGE_INTSCT_BUF 21

void CheckNodraws (void)
{
    int i, j, k, l, is, js;
    int numSetFromSingleSide = 0, numSetPointingDown = 0, numSetFromCompositeSide = 0, iBrushNumSet = 0;
 
    /* Initialise compositeSides[].. Note that this function
     * calls Check_NearList to initialise mapbrush_t.nearBrushes */
    Check_FindCompositeSides();
 
    /* check each brush, i, for downward sides */
    for (i = 0; i < nummapbrushes; i++) {
        mapbrush_t* iBrush = &mapbrushes[i];
        iBrushNumSet = 0;
 
        /* skip moving brushes, clips etc */
        if (!Check_IsOptimisable(iBrush))
            continue;
 
        /* check each side of i for pointing down */
        for (is = 0; is < iBrush->numsides; is++) {
            side_t* iSide = &iBrush->original_sides[is];
 
            /* skip those that are already nodraw */
            if (Check_SurfProp(SURF_NODRAW, iSide))
                continue;
            /* surface lights may point downwards */
            else if (iSide->surfaceFlags & SURF_LIGHT)
                continue;
 
            if (Check_SidePointsDown(iSide)) {
                Check_SetNodraw(iSide);
                numSetPointingDown++;
                iBrushNumSet++;
            }
 
        }
        if (iBrushNumSet)
            Check_Printf(VERB_EXTRA, true, iBrush->entitynum, iBrush->brushnum, "set nodraw on %i sides (point down, or are close to pointing down).\n", iBrushNumSet);
    } /* next iBrush for downward faces that can be nodraw */
    if (numSetPointingDown)
        Check_Printf(VERB_CHECK, true, -1, -1, "total of %i nodraws set (point down, or are close to pointing down)\n", numSetPointingDown);
 
    /* check each brush, i, for hidden sides */
    for (i = 0; i < nummapbrushes; i++) {
        mapbrush_t* iBrush = &mapbrushes[i];
        iBrushNumSet = 0;
 
        /* skip moving brushes, clips etc */
        if (!Check_IsOptimisable(iBrush))
            continue;
 
        /* check each brush, j, for having a side that hides one of i's faces */
        for (j = 0; j < iBrush->numNear; j++) {
            mapbrush_t* jBrush = iBrush->nearBrushes[j];
 
            /* skip moving brushes, clips etc */
            if (!Check_IsOptimisable(jBrush))
                continue;
 
            /* check each side of i for being hidden */
            for (is = 0; is < iBrush->numsides; is++) {
                side_t* iSide = &iBrush->original_sides[is];
 
                if (!iSide->winding)
                    continue; /* AddBrushBevels adds sides with no windings. skip these */
 
                /* skip those that are already nodraw */
                if (Check_SurfProp(SURF_NODRAW, iSide))
                    continue;
                /* surface lights may point downwards */
                else if (iSide->surfaceFlags & SURF_LIGHT)
                    continue;
 
                /* check each side of brush j for doing the hiding */
                for (js = 0; js < jBrush->numsides; js++) {
                    const side_t* jSide = &jBrush->original_sides[js];
 
                    if (!jSide->winding)
                        continue; /* AddBrushBevels adds sides with no windings. skip these */
 
#if 0
                    /* run on a largish map, this section proves that the plane indices alone cannot
                     * cannot be relied on to test for 2 planes facing each other. */
                    if (FacingAndCoincidentTo(iSide, jSide)) {
                        const int minIndex = std::min(iSide->planenum, jSide->planenum);
                        const int maxIndex = std::max(iSide->planenum, jSide->planenum);
                        const int diff = maxIndex - minIndex, minOdd = (minIndex & 1);
                        if ((diff != 1) || minOdd) {
                            Com_Printf("CheckNodraws: facing and coincident plane indices %i %i diff:%i minOdd:%i\n",
                                iSide->planenum, jSide->planenum, diff, minOdd);
                        }
                    }
#endif
 
                    if (Check_LevelForNodraws(jSide, iSide) &&
                        FacingAndCoincidentTo(iSide, jSide) &&
                        Check_SideIsInBrush(iSide, jBrush, PIB_INCL_SURF)) {
                        Check_SetNodraw(iSide);
                        iBrushNumSet++;
                        numSetFromSingleSide++;
                    }
                }
            }
        } /* next jBrush */
        if (iBrushNumSet)
            Check_Printf(VERB_EXTRA, true, iBrush->entitynum, iBrush->brushnum, "set nodraw on %i sides (covered by another brush).\n", iBrushNumSet);
 
        iBrushNumSet = 0; /* reset to count composite side coverings */
 
        /* check each composite side for hiding one of iBrush's sides */
        for (j = 0; j < numCompositeSides; j++) {
            const compositeSide_t* composite = &compositeSides[j];
            assert(composite);
            assert(composite->memberSides[0]);
 
            /* check each side for being hidden */
            for (is = 0; is < iBrush->numsides; is++) {
                side_t* iSide = &iBrush->original_sides[is];
                winding_t* iWinding;
                vec3_t lastIntersection = {0, 0, 0}; /* used in innner loop, here to avoid repeated memset calls */
 
                if (!FacingAndCoincidentTo(iSide, composite->memberSides[0]))
                    continue; /* all sides in the composite are parallel, and iSide must face them to be hidden */
 
                /* skip those that are already nodraw. note: this includes sides hidden by single sides
                 * set above - this prevents duplicate nodraw reports */
                if (Check_SurfProp(SURF_NODRAW, iSide))
                    continue;
 
                iWinding = iSide->winding;
 
                if (!iWinding)
                    continue; /* AddBrushBevels adds sides with no windings. skip these */
 
                /* to be covered each vertex of iSide must be on one of the composite side's members */
                for (k = 0; k < iWinding->numpoints; k++) {
                    bool pointOnComposite = false;
                    for (l = 0; l < composite->numMembers; l++) {
                        if (Check_IsPointInsideBrush(iWinding->p[k], composite->memberSides[l]->brush, PIB_INCL_SURF)) {
 
                            /* levelflags mean this member cannot cover iSide
                             * might be wrong to assume the composite will not cover iSide (if the members intersect)
                              * it is _safe_ in that it will not result in an exposed nodraw */
                            if (!Check_LevelForNodraws(composite->memberSides[l], iSide))
                                goto next_iSide;
 
                            pointOnComposite = true;
                            break;
                        }
                    }
                    if (!pointOnComposite)
                        goto next_iSide;
                }
 
                /* search for intersections between composite and iSide */
                for (k = 0; k < iWinding->numpoints; k++) {
                    vec3_t intersection;
                    int lastIntersectionMembInd = -1;
                    vec3_t intersections[CH_COMP_NDR_EDGE_INTSCT_BUF];
                    bool paired[CH_COMP_NDR_EDGE_INTSCT_BUF];
                    int numIntsct = 0;
 
                    OBJZERO(paired);
 
                    for (l = 0; l < composite->numMembers; l++) {
                        const winding_t* mWinding = composite->memberSides[l]->winding;
 
                        for (int m = 0; m < mWinding->numpoints; m++) {
                            bool intersects = Check_EdgeEdgeIntersection(
                                iWinding->p[k], iWinding->p[(k + 1) % iWinding->numpoints],
                                mWinding->p[m], mWinding->p[(m + 1) % mWinding->numpoints],
                                intersection);
 
                            if (intersects) {
                                bool coincident = false;
                                /* check for coincident intersections */
                                for (int n = 0; n < numIntsct; n++) {
                                    float distSq = VectorDistSqr(intersection, intersections[n]);
                                    if (CH_DIST_EPSILON_SQR > distSq) {
                                        paired[n] = true;
                                        coincident = true;
                                    }
                                }
 
                                /* if it is not coincident, then add it to the list */
                                if (!coincident) {
                                    VectorCopy(intersection, intersections[numIntsct]);
                                    numIntsct++;
                                    if (numIntsct >= CH_COMP_NDR_EDGE_INTSCT_BUF) {
                                        Check_Printf(VERB_LESS, false, -1, -1, "warning: CheckNodraws: buffer too small\n");
                                        return;
                                    }
                                }
 
                                /* if edge k of iSide crosses side l of composite then check levelflags */
                                /* note that as each member side is convex any line can intersect its edges a maximum of twice,
                                 * as the member sides of the composite are the inner loop, these two (if they exist) will
                                 * be found consecutively */
                                if ((lastIntersectionMembInd == l) /* same composite as last intersection found */
                                 && (VectorDistSqr(intersection, lastIntersection) > CH_DIST_EPSILON_SQR) /* dist between this and last intersection is nonzero, indicating they are different intersections */
                                 && !Check_LevelForNodraws(composite->memberSides[l], iSide)) /* check nodraws */
                                    goto next_iSide;
 
                                lastIntersectionMembInd = l;
                                VectorCopy(intersection, lastIntersection);
                            }
                        }
                    }
 
                    /* make sure all intersections are paired. an unpaired intersection indicates
                     * that iSide's boundary crosses out of the composite side, so iSide is not hidden */
                    for (l = 0; l < numIntsct; l++) {
                        if (!paired[l])
                            goto next_iSide;
                    }
 
                }
 
                /* set nodraw for iSide (covered by composite) */
                Check_SetNodraw(iSide);
                iBrushNumSet++;
                numSetFromCompositeSide++;
 
                next_iSide:
                ;
            }
        } /* next composite */
        if (iBrushNumSet)
            Check_Printf(VERB_EXTRA, true, iBrush->entitynum, iBrush->brushnum, "set nodraw on %i sides (covered by a composite side).\n", iBrushNumSet);
    } /* next iBrush */
 
    if (numSetFromSingleSide)
        Check_Printf(VERB_CHECK, true, -1, -1, "%i nodraws set (covered by another brush).\n", numSetFromSingleSide);
 
    if (numSetFromCompositeSide)
        Check_Printf(VERB_CHECK, true, -1, -1, "%i nodraws set (covered by a composite side).\n", numSetFromCompositeSide);
 
}

static bool Check_DuplicateBrushPlanes (const mapbrush_t* b)
{
    const side_t* sides = b->original_sides;
 
    for (int i = 1; i < b->numsides; i++) {
        /* check for duplication and mirroring */
        for (int j = 0; j < i; j++) {
            if (sides[i].planenum == sides[j].planenum) {
                /* remove the second duplicate */
                Check_Printf(VERB_CHECK, false, b->entitynum, b->brushnum, "mirrored or duplicated\n");
                break;
            }
 
            if (sides[i].planenum == (sides[j].planenum ^ 1)) {
                Check_Printf(VERB_CHECK, false, b->entitynum, b->brushnum, "mirror plane - brush is invalid\n");
                return false;
            }
        }
    }
    return true;
}

static vec_t Check_MapBrushVolume (const mapbrush_t* brush)
{
    int i;
    const winding_t* w;
    vec3_t corner;
    vec_t d, area, volume;
    const plane_t* plane;
 
    if (!brush)
        return 0;
 
    /* grab the first valid point as the corner */
    w = nullptr;
    for (i = 0; i < brush->numsides; i++) {
        w = brush->original_sides[i].winding;
        if (w)
            break;
    }
    if (!w)
        return 0;
    VectorCopy(w->p[0], corner);
 
    /* make tetrahedrons to all other faces */
    volume = 0;
    for (; i < brush->numsides; i++) {
        w = brush->original_sides[i].winding;
        if (!w)
            continue;
        plane = &mapplanes[brush->original_sides[i].planenum];
        d = -(DotProduct(corner, plane->normal) - plane->dist);
        area = WindingArea(w);
        volume += d * area;
    }
 
    return volume / 3;
}

void CheckMapMicro (void)
{
    for (int i = 0; i < nummapbrushes; i++) {
        mapbrush_t* brush = &mapbrushes[i];
        const float vol = Check_MapBrushVolume(brush);
        if (vol < config.mapMicrovol) {
            Check_Printf(VERB_CHECK, true, brush->entitynum, brush->brushnum, "microbrush volume %f - will be deleted\n", vol);
            brush->skipWriteBack = true;
        }
    }
}

void DisplayContentFlags (const int flags)
{
    if (!flags) {
        Check_Printf(VERB_CHECK, false, NUM_SAME, NUM_SAME, " no contentflags");
        return;
    }
#define M(x) if (flags & CONTENTS_##x) Check_Printf(VERB_CHECK, false, NUM_SAME, NUM_SAME, " " #x)
    M(SOLID);
    M(WINDOW);
    M(LADDER);
    M(WATER);
    M(LEVEL_1);
    M(LEVEL_2);
    M(LEVEL_3);
    M(LEVEL_4);
    M(LEVEL_5);
    M(LEVEL_6);
    M(LEVEL_7);
    M(LEVEL_8);
    M(ACTORCLIP);
    M(PASSABLE);
    M(ACTOR);
    M(ORIGIN);
    M(WEAPONCLIP);
    M(DEADACTOR);
    M(DETAIL);
    M(TRANSLUCENT);
#undef M
}

static int Check_CalculateLevelFlagFill (int contentFlags)
{
    int firstSetLevel = 0, lastSetLevel = 0;
    int scanLevel, flagFill = 0;
 
    for (scanLevel = CONTENTS_LEVEL_1; scanLevel <= CONTENTS_LEVEL_8; scanLevel <<= 1) {
        if (scanLevel & contentFlags) {
            if (!firstSetLevel) {
                firstSetLevel = scanLevel;
            } else {
                lastSetLevel = scanLevel;
            }
        }
    }
    for (scanLevel = firstSetLevel << 1 ; scanLevel < lastSetLevel; scanLevel <<= 1)
        flagFill |= scanLevel & ~contentFlags;
    return flagFill;
}

void CheckFillLevelFlags (void)
{
    for (int i = 0; i < nummapbrushes; i++) {
        mapbrush_t* brush = &mapbrushes[i];
 
        /* CheckLevelFlags should be done first, so we will boldly
         * assume that levelflags are the same on each face */
        int flagFill = Check_CalculateLevelFlagFill(brush->original_sides[0].contentFlags);
        if (flagFill) {
            Check_Printf(VERB_CHECK, true, brush->entitynum, brush->brushnum, "making set levelflags continuous by setting");
            DisplayContentFlags(flagFill);
            Check_Printf(VERB_CHECK, true, brush->entitynum, brush->brushnum, "\n");
            for (int j = 0; j < brush->numsides; j++)
                brush->original_sides[j].contentFlags |= flagFill;
        }
    }
}

void CheckLevelFlags (void)
{
    bool setFlags;
    int allLevelFlagsForBrush;
 
    for (int i = 0; i < nummapbrushes; i++) {
        mapbrush_t* brush = &mapbrushes[i];
        int j;
 
        /* test if all faces are nodraw */
        bool allNodraw = true;
        for (j = 0; j < brush->numsides; j++) {
            const side_t* side = &brush->original_sides[j];
            assert(side);
 
            if (!(Check_SurfProp(SURF_NODRAW, side))) {
                allNodraw = false;
                break;
            }
        }
 
        /* proceed if some or all faces are not nodraw */
        if (!allNodraw) {
            allLevelFlagsForBrush = 0;
 
            setFlags = false;
            /* test if some faces do not have levelflags and remember
             * all levelflags which are set. */
            for (j = 0; j < brush->numsides; j++) {
                const side_t* side = &brush->original_sides[j];
 
                allLevelFlagsForBrush |= (side->contentFlags & CONTENTS_LEVEL_ALL);
 
                if (!(side->contentFlags & (CONTENTS_ORIGIN | MASK_CLIP))) {
                    /* check level 1 - level 8 */
                    if (!(side->contentFlags & CONTENTS_LEVEL_ALL)) {
                        setFlags = true;
                        break;
                    }
                }
            }
 
            /* set the same flags for each face */
            if (setFlags) {
                const int flagsToSet = allLevelFlagsForBrush ? allLevelFlagsForBrush : CONTENTS_LEVEL_ALL;
                Check_Printf(VERB_CHECK, true, brush->entitynum, brush->brushnum, "at least one face has no levelflags, setting %i on all faces\n", flagsToSet);
                for (j = 0; j < brush->numsides; j++) {
                    side_t* side = &brush->original_sides[j];
                    side->contentFlags |= flagsToSet;
                }
            }
        }
    }
}

void SetImpliedFlags (side_t* side, brush_texture_t* tex, const mapbrush_t* brush)
{
    const char* texname = tex->name;
    const int initSurf = tex->surfaceFlags;
    const int initCont = side->contentFlags;
 
    /* see discussion at Check_SetNodraw */
    if (!config.fixMap && !config.performMapCheck) {
        const char* flagsDescription = nullptr;
        if (Q_streq(texname, "tex_common/actorclip")) {
            side->contentFlags |= CONTENTS_ACTORCLIP;
            flagsDescription = "CONTENTS_ACTORCLIP";
        } else if (Q_streq(texname, "tex_common/caulk")) {
            side->surfaceFlags |= SURF_NODRAW;
            tex->surfaceFlags |= SURF_NODRAW;
            flagsDescription = "SURF_NODRAW";
        } else if (Q_streq(texname, "tex_common/hint")) {
            side->surfaceFlags |= SURF_HINT;
            tex->surfaceFlags |= SURF_HINT;
            flagsDescription = "SURF_HINT";
        } else if (Q_streq(texname, "tex_common/ladder")) {
            side->contentFlags |= CONTENTS_LADDER;
            side->surfaceFlags |= SURF_NODRAW;
            tex->surfaceFlags |= SURF_NODRAW;
            flagsDescription = "CONTENTS_LADDER";
        } else if (Q_streq(texname, "tex_common/lightclip")) {
            side->contentFlags |= CONTENTS_LIGHTCLIP;
            flagsDescription = "CONTENTS_LIGHTCLIP";
        } else if (Q_streq(texname, "tex_common/nodraw")) {
            /*side->contentFlags |= CONTENTS_SOLID;*/
            side->surfaceFlags |= SURF_NODRAW;
            tex->surfaceFlags |= SURF_NODRAW;
            flagsDescription = "SURF_NODRAW";
        } else if (Q_streq(texname, "tex_common/trigger")) {
            side->surfaceFlags |= SURF_NODRAW;
            tex->surfaceFlags |= SURF_NODRAW;
            flagsDescription = "SURF_NODRAW";
        } else if (Q_streq(texname, "tex_common/origin")) {
            side->contentFlags |= CONTENTS_ORIGIN;
            flagsDescription = "CONTENTS_ORIGIN";
        } else if (Q_streq(texname, "tex_common/slick")) {
            side->contentFlags |= SURF_SLICK;
            flagsDescription = "SURF_SLICK";
        } else if (Q_streq(texname, "tex_common/weaponclip")) {
            side->contentFlags |= CONTENTS_WEAPONCLIP;
            flagsDescription = "CONTENTS_WEAPONCLIP";
        }
 
        if (strstr(texname, "water")) {
#if 0
            side->surfaceFlags |= SURF_WARP;
            tex->surfaceFlags |= SURF_WARP;
#endif
            side->contentFlags |= CONTENTS_WATER;
            side->contentFlags |= CONTENTS_PASSABLE;
            flagsDescription = "CONTENTS_WATER and CONTENTS_PASSABLE";
        }
 
        /* If in check/fix mode and we have made a change, give output. */
        if ((side->contentFlags != initCont) || (tex->surfaceFlags != initSurf)) {
            Check_Printf(VERB_CHECK, true, brush->entitynum, brush->brushnum,
                    "%s implied by %s texture has been set\n", flagsDescription ? flagsDescription : "-", texname);
        }
    }
 
    /* additional test, which does not directly depend on tex. */
    if (Check_SurfProp(SURF_NODRAW, side) && (tex->surfaceFlags & SURF_PHONG)) {
        /* nodraw never has phong set */
        side->surfaceFlags &= ~SURF_PHONG;
        tex->surfaceFlags &= ~SURF_PHONG;
        Check_Printf(VERB_CHECK, true, brush->entitynum, brush->brushnum,
            "SURF_PHONG unset, as it has SURF_NODRAW set\n");
    }
 
    if (side->surfaceFlags & SURF_SKIP) {
        side->surfaceFlags &= ~SURF_SKIP;
        Check_Printf(VERB_CHECK, true, brush->entitynum, brush->brushnum,
            "removing legacy flag, SURF_SKIP\n");
    }
}

void CheckFlagsBasedOnTextures (void)
{
    for (int i = 0; i < nummapbrushes; i++) {
        mapbrush_t* brush = &mapbrushes[i];
 
        for (int j = 0; j < brush->numsides; j++) {
            side_t* side = &brush->original_sides[j];
            const ptrdiff_t index = side - brushsides;
            brush_texture_t* tex = &side_brushtextures[index];
 
            assert(side);
            assert(tex);
 
            /* set surface and content flags based on texture. */
            SetImpliedFlags(side, tex, brush);
        }
    }
}

void CheckTexturesBasedOnFlags (void)
{
    for (int i = 0; i < nummapbrushes; i++) {
        mapbrush_t* brush = &mapbrushes[i];
 
        for (int j = 0; j < brush->numsides; j++) {
            side_t* side = &brush->original_sides[j];
            const ptrdiff_t index = side - brushsides;
            brush_texture_t* tex = &side_brushtextures[index];
 
            assert(side);
            assert(tex);
 
            /* set textures based on flags */
            if (tex->name[0] == '\0') {
                Check_Printf(VERB_CHECK, false, brush->entitynum, brush->brushnum, " no texture assigned\n");
            }
 
            if (Q_streq(tex->name, "tex_common/error")) {
                Check_Printf(VERB_CHECK, false, brush->entitynum, brush->brushnum, "error texture assigned - check this brush\n");
            }
 
            if (Q_streq(tex->name, "nullptr")) {
                Check_Printf(VERB_CHECK, true, brush->entitynum, brush->brushnum, "replaced nullptr with nodraw texture\n");
                Q_strncpyz(tex->name, "tex_common/nodraw", sizeof(tex->name));
                tex->surfaceFlags |= SURF_NODRAW;
            }
            if ((tex->surfaceFlags & SURF_NODRAW) && !Q_streq(tex->name, "tex_common/nodraw")) {
                Check_Printf(VERB_CHECK, true, brush->entitynum, brush->brushnum, "set nodraw texture for SURF_NODRAW\n");
                tex->surfaceFlags &= ~SURF_PHONG;
                side->surfaceFlags &= ~SURF_PHONG;
                Q_strncpyz(tex->name, "tex_common/nodraw", sizeof(tex->name));
            }
            if ((tex->surfaceFlags & SURF_HINT) && !Q_streq(tex->name, "tex_common/hint")) {
                Check_Printf(VERB_CHECK, true, brush->entitynum, brush->brushnum,  "set hint texture for SURF_HINT\n");
                Q_strncpyz(tex->name, "tex_common/hint", sizeof(tex->name));
            }
 
            if ((side->contentFlags & CONTENTS_WEAPONCLIP) && !Q_streq(tex->name, "tex_common/weaponclip")) {
                Check_Printf(VERB_CHECK, true, brush->entitynum, brush->brushnum,  "set weaponclip texture for CONTENTS_WEAPONCLIP\n");
                Q_strncpyz(tex->name, "tex_common/weaponclip", sizeof(tex->name));
            }
            if ((side->contentFlags & CONTENTS_ACTORCLIP) && !Q_streq(tex->name, "tex_common/actorclip")) {
                Check_Printf(VERB_CHECK, true, brush->entitynum, brush->brushnum,  "set actorclip texture for CONTENTS_ACTORCLIP\n");
                Q_strncpyz(tex->name, "tex_common/actorclip", sizeof(tex->name));
            }
            if ((side->contentFlags & CONTENTS_LIGHTCLIP) && !Q_streq(tex->name, "tex_common/lightclip")) {
                Check_Printf(VERB_CHECK, true, brush->entitynum, brush->brushnum,  "set lightclip texture for CONTENTS_LIGHTCLIP\n");
                Q_strncpyz(tex->name, "tex_common/lightclip", sizeof(tex->name));
            }
            if ((side->contentFlags & CONTENTS_ORIGIN) && !Q_streq(tex->name, "tex_common/origin")) {
                Check_Printf(VERB_CHECK, true, brush->entitynum, brush->brushnum, "set origin texture for CONTENTS_ORIGIN\n");
                Q_strncpyz(tex->name, "tex_common/origin", sizeof(tex->name));
            }
        }
    }
}

void CheckPropagateParserContentFlags(mapbrush_t* b)
{
    int notInformedMixedFace = 1;
    int transferFlags = (CONTENTS_DETAIL | CONTENTS_TRANSLUCENT);
 
    for (int m = 0; m < b->numsides; m++) {
        int contentFlagDiff = (b->original_sides[m].contentFlags ^ b->contentFlags) & transferFlags;
        if (contentFlagDiff) {
            /* only tell them once per brush */
            if (notInformedMixedFace) {
                Check_Printf(VERB_CHECK, true, b->entitynum , b->brushnum, "transferring contentflags to all faces:");
                DisplayContentFlags(contentFlagDiff);
                Check_Printf(VERB_CHECK, true, b->entitynum , b->brushnum, "\n");
                notInformedMixedFace = 0;
            }
            b->original_sides[m].contentFlags |= b->contentFlags ;
        }
    }
}

void CheckMixedFaceContents (void)
{
    int nfActorclip; /* number of faces with actorclip contentflag set */
 
    for (int i = 0; i < nummapbrushes; i++) {
        mapbrush_t* brush = &mapbrushes[i];
        side_t* side0;
        int j;
 
        /* if the origin flag is set in the mapbrush_t struct, then the brushes
         * work is done, and we can skip the mixed face contents check for this brush */
        if (brush->contentFlags & CONTENTS_ORIGIN)
            continue;
 
        side0 = &brush->original_sides[0];
        nfActorclip = 0;
 
        CheckPropagateParserContentFlags(brush);
 
        for (j = 0; j < brush->numsides; j++) {
            side_t* side = &brush->original_sides[j];
            assert(side);
 
            nfActorclip += (side->contentFlags & CONTENTS_ACTORCLIP) ? 1 : 0;
 
            if (side0->contentFlags != side->contentFlags) {
                const int jNotZero = side->contentFlags & ~side0->contentFlags;
                const int zeroNotJ = side0->contentFlags & ~side->contentFlags;
                Check_Printf(VERB_CHECK, false, brush->entitynum, brush->brushnum, "mixed face contents (");
                if (jNotZero) {
                    Check_Printf(VERB_CHECK, false, NUM_SAME, NUM_SAME, "face %i has and face 0 has not", j);
                    DisplayContentFlags(jNotZero);
                    if (zeroNotJ)
                        Check_Printf(VERB_CHECK, false, NUM_SAME, NUM_SAME, ", ");
                }
                if (zeroNotJ) {
                    Check_Printf(VERB_CHECK, false, NUM_SAME, NUM_SAME, "face 0 has and face %i has not", j);
                    DisplayContentFlags(zeroNotJ);
                }
                Check_Printf(VERB_CHECK, false, NUM_SAME, NUM_SAME, ")\n");
            }
        }
 
        if (nfActorclip && nfActorclip != brush->numsides) {
            Check_Printf(VERB_CHECK, true, brush->entitynum, brush->brushnum, "ACTORCLIP is not set on all of the faces: removing.\n");
            for (j = 0; j < brush->numsides; j++) {
                side_t* side = &brush->original_sides[j];
                const ptrdiff_t index = side - brushsides;
                brush_texture_t* tex = &side_brushtextures[index];
 
                if ((side->contentFlags & CONTENTS_ACTORCLIP) && Q_streq(tex->name, "tex_common/actorclip")) {
                    Check_Printf(VERB_CHECK, true, brush->entitynum, brush->brushnum, "removing tex_common/actorclip, setting tex_common/error\n");
                    Q_strncpyz(tex->name, "tex_common/error", sizeof(tex->name));
                }
 
                side->contentFlags &= ~CONTENTS_ACTORCLIP;
            }
        }
    }
}
 
void CheckBrushes (void)
{
    for (int i = 0; i < nummapbrushes; i++) {
        mapbrush_t* brush = &mapbrushes[i];
 
        Check_DuplicateBrushPlanes(brush);
 
        for (int j = 0; j < brush->numsides; j++) {
            side_t* side = &brush->original_sides[j];
 
            assert(side);
 
            if ((side->contentFlags & CONTENTS_ORIGIN) && brush->entitynum == 0) {
                Check_Printf(VERB_CHECK, true, brush->entitynum, brush->brushnum, "origin brush inside worldspawn - removed CONTENTS_ORIGIN\n");
                side->contentFlags &= ~CONTENTS_ORIGIN;
            }
        }
    }
}